From ff1dba1e0c6f190da55d2799ebaa7a167f49ae9a Mon Sep 17 00:00:00 2001 From: Szymon Marczak <36894700+szmarczak@users.noreply.github.com> Date: Sat, 8 Feb 2020 18:45:44 +0100 Subject: [PATCH] Fix `_pagination` not falling back to defaults --- source/normalize-arguments.ts | 2 +- test/pagination.ts | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/source/normalize-arguments.ts b/source/normalize-arguments.ts index 00f6ef251..fb7c3548e 100644 --- a/source/normalize-arguments.ts +++ b/source/normalize-arguments.ts @@ -200,7 +200,7 @@ export const preNormalizeArguments = (options: Options, defaults?: NormalizedOpt // `options._pagination` if (is.object(options._pagination)) { - if (defaults && !(Reflect.has(options, 'pagination') && is.undefined(options._pagination))) { + if (defaults && !(Reflect.has(options, '_pagination') && is.undefined(options._pagination))) { options._pagination = { ...defaults.pagination, ...options._pagination diff --git a/test/pagination.ts b/test/pagination.ts index dce9a44d8..c55b0c767 100644 --- a/test/pagination.ts +++ b/test/pagination.ts @@ -47,6 +47,14 @@ test('retrieves all elements', withServer, async (t, server, got) => { t.deepEqual(result, [1, 2]); }); +test('points to defaults when extending Got without custom `_pagination`', withServer, async (t, server, got) => { + attachHandler(server, 2); + + const result = await got.extend().paginate.all(''); + + t.deepEqual(result, [1, 2]); +}); + test('filters elements', withServer, async (t, server, got) => { attachHandler(server, 3);