-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Dart Sass #278
Comments
We could remove Something like: let sass;
try {
sass = require('dart-sass');
} catch (_) {
sass = require('node-sass');
} |
I think the const engine = opt.engine || require('node-sass');
...
engine.render(..) In time we could move towards having both as |
IMHO, either both are dependencies or none are. |
This could work, but it does mean that users can't explicitly configure which implementation of Sass they want to use. For example, a user may transitively depend on Node Sass for some entirely different reason (maybe a component uses it for its own CSS) but want to use Dart Sass with Grunt. Or maybe a user wants to use a version of Dart Sass that's installed locally to test out a change they're working on.
One of the big benefits of Dart Sass is avoiding the installation headaches of Node Sass. If |
I understand. The intent for One thing we can do is make node-sass an optional dependency. This way if |
It's up to you, but I really think users would be happier with no built-in dependency from |
I came across this thread and wanted to chime in. I too was looking for a grunt plugin that uses Dart Sass instead of the now deprecated Ruby Sass after making the switch. I went ahead a built a similar package to this one, |
|
One last thing |
Actually maybe that only updates once published a new version. |
Dart Sass has been released, and it would be great to add support to this package for choosing between Node Sass and Dart Sass. I'm willing to create a pull request, but I'm not sure what the best design would be.
The text was updated successfully, but these errors were encountered: