Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .isWeakRef() #164

Closed

Conversation

bigbigDreamer
Copy link
Contributor

@bigbigDreamer bigbigDreamer commented Mar 1, 2022

Changes as follow, Support #143 :

  1. Support ts complier for WeakRef: update typescript to v 4.6.2(latest)
  2. Support test mock with JSDOM: update jsdom to v 19.0.0(latest)
  3. Fix lint error: test code perf #163
  4. Add complierOptions for tsconfig.xo.json: fix follow error, However, the ide still reports an error. I don't quite clear which tsconfig the test file is ultimately controlled by. It seems that the addition is invalid.
    • image

@bigbigDreamer
Copy link
Contributor Author

image

All tests can passed in my local env.I don't know why ci doesn't pass. @sindresorhus

@bigbigDreamer
Copy link
Contributor Author

Sorry, I may have used --rebase upstream, so my commits are so ugly.

@sindresorhus
Copy link
Owner

You should always make a separate branch for each pull request.

@bigbigDreamer
Copy link
Contributor Author

You should always make a separate branch for each pull request.

Ok, when I get home later and reopen a branch, I just arrived at the company now, ready to work.

@bigbigDreamer bigbigDreamer mentioned this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants