Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about new dependencies #624

Closed
mmkal opened this issue Sep 17, 2021 · 2 comments · Fixed by #681
Closed

Warn about new dependencies #624

mmkal opened this issue Sep 17, 2021 · 2 comments · Fixed by #681

Comments

@mmkal
Copy link
Collaborator

mmkal commented Sep 17, 2021

Description

It'd be nice if np would ask me if I deliberately added a dependency (as opposed to forgetting to use yarn add --dev). Similar to the new files check.

Is the feature request related to a problem?

I accidentally published a version of my package with a non production-ready and unnecessary dependency, and I'm looking for something to blame other than my own stupidity.

Possible implementation

I assume, very similarly to the new files feature. I haven't looked at the implementation of this package.

Alternatives

Always remember to use --dev when using yarn add. That is completely impossible though. There is a 100% chance that I will forget again at some point.

@itaisteinherz
Copy link
Collaborator

@mmkal I like this idea :)
I'm not sure how I feel about adding another confirmation step though (as opposed to a simple notice message).

@mmkal
Copy link
Collaborator Author

mmkal commented Sep 21, 2021

Maybe it could be bundled into the same confirmation step as "new files"? A notice message that doesn't stop the process sounds stressful - is the user supposed to be really fast with their ctrl-c hand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants