You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there! I know this has been raised a quite a few times (#694, #638, #628, #251), but I figured worth asking again because:
Since most of those issues, corepack became a thing and the packageManager field was introduced to package.json, with pnpm being an officially supported package manager by nodejs itself. corepack means that we wouldn't need to worry about versions of pnpm, or anything like that - if the user cares, they'd just specify it in packageManager as normal.
I really don't think it'd be too hard! I use np with pnpm already, and all you have to do is set "np": {"cleanup": false} in package.json. But doing this is a shame, because the cleanup feature is helpful. And needing to remember to do it just adds friction.
Looking at the code, there's a fair amount of messiness related to yarn and yarn berry. In my experience, pnpm is better behaved, and does more work for you, so I don't think it'd add to that messiness. I think a small refactor could make it cleaner/more maintainable overall - basically we'd just need to abstract the install node_modules and run a package.json script concepts.
pnpm really is better, and it's being adopted more and more, so it's less of a niche request than it was in 2018.
So, my pitch is: if I could submit a PR that didn't add net complexity/maintenance burden, would it be accepted? I'd also be happy to help with maintaining it indefinitely - looking at pnpm-related bugs/pull requests etc.
The text was updated successfully, but these errors were encountered:
Hi there! I know this has been raised a quite a few times (#694, #638, #628, #251), but I figured worth asking again because:
corepack
became a thing and the packageManager field was introduced to package.json, with pnpm being an officially supported package manager by nodejs itself. corepack means that we wouldn't need to worry about versions of pnpm, or anything like that - if the user cares, they'd just specify it inpackageManager
as normal.np
with pnpm already, and all you have to do is set"np": {"cleanup": false}
in package.json. But doing this is a shame, because the cleanup feature is helpful. And needing to remember to do it just adds friction.install node_modules
andrun a package.json script
concepts.So, my pitch is: if I could submit a PR that didn't add net complexity/maintenance burden, would it be accepted? I'd also be happy to help with maintaining it indefinitely - looking at pnpm-related bugs/pull requests etc.
The text was updated successfully, but these errors were encountered: