Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm in 2024? #729

Closed
mmkal opened this issue Jan 30, 2024 · 1 comment · Fixed by #730
Closed

Support pnpm in 2024? #729

mmkal opened this issue Jan 30, 2024 · 1 comment · Fixed by #730

Comments

@mmkal
Copy link
Collaborator

mmkal commented Jan 30, 2024

Hi there! I know this has been raised a quite a few times (#694, #638, #628, #251), but I figured worth asking again because:

  1. Since most of those issues, corepack became a thing and the packageManager field was introduced to package.json, with pnpm being an officially supported package manager by nodejs itself. corepack means that we wouldn't need to worry about versions of pnpm, or anything like that - if the user cares, they'd just specify it in packageManager as normal.
  2. I really don't think it'd be too hard! I use np with pnpm already, and all you have to do is set "np": {"cleanup": false} in package.json. But doing this is a shame, because the cleanup feature is helpful. And needing to remember to do it just adds friction.
  3. Looking at the code, there's a fair amount of messiness related to yarn and yarn berry. In my experience, pnpm is better behaved, and does more work for you, so I don't think it'd add to that messiness. I think a small refactor could make it cleaner/more maintainable overall - basically we'd just need to abstract the install node_modules and run a package.json script concepts.
  4. pnpm really is better, and it's being adopted more and more, so it's less of a niche request than it was in 2018.

So, my pitch is: if I could submit a PR that didn't add net complexity/maintenance burden, would it be accepted? I'd also be happy to help with maintaining it indefinitely - looking at pnpm-related bugs/pull requests etc.

@sindresorhus
Copy link
Owner

I'm willing to support pnpm if you can commit to maintain the pnpm-specific parts of the code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants