You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I left a similar comment on a previously opened issue from a couple years ago: #146 (comment)
Since this has not been addressed, I'm opening another issue.
The problem is that EventEmitter v4 (currently used version here) does not have an export default, causing this to break when using TypeScript without the esModuleInterop or allowSyntheticDefaultImports set to true. This should not be required, and this import can be handled correctly.
There are 2 options:
Stay on the current EventEmitter v4 and in source\index.ts, update the first line to import * as EventEmitter from 'eventemitter3';
Upgrade to EventEmitter v5 (note: the breaking changes will not affect this repo), and either:
keep the import as is
OR, update it to import { EventEmitter } from 'eventemitter3' (preferred syntax)
NOTE: either way works since v5 supports both here
Please make either of these very quick changes, or I cannot upgrade p-queue to v7 from v6. Thank you!
The text was updated successfully, but these errors were encountered:
I left a similar comment on a previously opened issue from a couple years ago: #146 (comment)
Since this has not been addressed, I'm opening another issue.
The problem is that
EventEmitter
v4 (currently used version here) does not have anexport default
, causing this to break when using TypeScript without theesModuleInterop
orallowSyntheticDefaultImports
set totrue
. This should not be required, and thisimport
can be handled correctly.There are 2 options:
EventEmitter
v4 and insource\index.ts
, update the first line toimport * as EventEmitter from 'eventemitter3';
EventEmitter
v5 (note: the breaking changes will not affect this repo), and either:import { EventEmitter } from 'eventemitter3'
(preferred syntax)Please make either of these very quick changes, or I cannot upgrade
p-queue
to v7 from v6. Thank you!The text was updated successfully, but these errors were encountered: