-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exact not function correctly with Dates since last commit #909
Comments
// @zorji |
Hi @nlynzaad I am trying to reproduce the issue but I can't in my IDE. Just want to clarify this with you, are you expecting the Exact type to throw error because |
Hi @zorji , Thanks for looking into this. Yes I'm expecting it to fail due to the additional "surname" property. I usually work in webstorm where I picked this issue up, confirmed now with vscode the editor show it as well and tsc also only fails using EXACT_OLD or with no date field |
for testing I got EXACT_OLD from the pre-commit diff and EXACT_NEW from current master. |
I created a stackblitz with the issue: Exact Issue |
@nlynzaad Thanks I can reproduce it when using a variable. Let me see if I can provide a fix. |
I drafted this fix #911 Do you mind help test if that fixes the issue for you? |
@zorji Thanks a lot. I copied the draft into the larger project and worked as intended |
Hi,
First off, I'm a new user of the project and just want to say thanks for your efforts in maintaining this exceptionally handy project.
Was struggling to get the Exact type to work and it seems to be related to a change that was made in commit #902, specifically the change from object to JsonObject. When having a date field, the validation does not throw an error as expected. The error however does appear in the version prior to the commit and in the new version if the Date field is removed.
Upvote & Fund
The text was updated successfully, but these errors were encountered: