Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs a better update command notification. #161

Closed
vivaxy opened this issue Jun 19, 2019 · 0 comments · Fixed by #165
Closed

Needs a better update command notification. #161

vivaxy opened this issue Jun 19, 2019 · 0 comments · Fixed by #165

Comments

@vivaxy
Copy link

vivaxy commented Jun 19, 2019

Environment

  • yarn installed
  • Previously installed a package with npm i -g package

Expected behaviour

Showing npm i -g package or yarn add package --global

Actual behaviour

Showing yarn add package

Discussion

It's better to have the logic as:

if (installed package with yarn global) {
  return 'yarn add package --global'
}
if (installed package with npm global) {
  return 'npm i -g package'
}
if (has yarn) {
  return 'yarn add package'
}
return 'npm i package'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant