fix: alphabetical sort method now handles missing data better (#125)

Co-authored-by: the_mcmurder <the_mcmurder@users.noreply.github.com>

src/modify.js

@@ -86,14 +86,12 @@ exports.modifyImportMap = function (env, newValues) {
   const { services, scopes } = newValues;
 
   const alphabetical = !!getConfig().alphabetical;
-  const newImports =
-    services && typeof services === "object" && alphabetical
-      ? sortObjectAlphabeticallyByKeys(services)
-      : services;
-  const newScopes =
-    scopes && typeof scopes === "object" && alphabetical
-      ? sortObjectAlphabeticallyByKeys(scopes)
-      : scopes;
+  const newImports = alphabetical
+    ? sortObjectAlphabeticallyByKeys(services)
+    : services;
+  const newScopes = alphabetical
+    ? sortObjectAlphabeticallyByKeys(scopes)
+    : scopes;
 
   // either imports or scopes have to be defined
   if (newImports || newScopes) {
@@ -160,10 +158,15 @@ exports.modifyService = function (
 exports.getEmptyManifest = getEmptyManifest;
 
 function sortObjectAlphabeticallyByKeys(unordered) {
+  if (!unordered) {
+    return unordered;
+  }
   return Object.keys(unordered)
     .sort()
     .reduce((obj, key) => {
       obj[key] = unordered[key];
       return obj;
     }, {});
 }
+
+exports.sortObjectAlphabeticallyByKeys = sortObjectAlphabeticallyByKeys;

test/alphabetical-import-map.test.js

@@ -3,6 +3,7 @@ const { app, setConfig } = require("../src/web-server");
 const {
   resetManifest: resetMemoryManifest,
 } = require("../src/io-methods/memory");
+const { sortObjectAlphabeticallyByKeys } = require("../src/modify.js");
 
 describe(`alphabetically sorted`, () => {
   beforeAll(() => {
@@ -58,6 +59,12 @@ describe(`alphabetically sorted`, () => {
       `{"a":"/a-1-updated.mjs","b":"/b-1.mjs","c":"/c-1.mjs"}`
     );
   });
+
+  it("should return undefined or null if you pass them in and not throw an error", () => {
+    expect(sortObjectAlphabeticallyByKeys(undefined)).toBe(undefined);
+    expect(sortObjectAlphabeticallyByKeys(null)).toBe(null);
+    expect(JSON.stringify(sortObjectAlphabeticallyByKeys({}))).toBe("{}");
+  });
 });
 
 describe(`not alphabetically sorted`, () => {