fix: alphabetical sort method now handles missing data better #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMcMurder
commented
Oct 22, 2021
| @@ -86,14 +86,12 @@ exports.modifyImportMap = function (env, newValues) { | |||
| const { services, scopes } = newValues; | |||
|
|
|||
| const alphabetical = !!getConfig().alphabetical; | |||
| const newImports = | |||
| services && typeof services === "object" && alphabetical | |||
There was a problem hiding this comment.
I added all this last time. I could've saved myself a fair amount of pain by making sortObjectAlphabeticallyByKeys handle unexpected data better, which is what this PR does.
TheMcMurder
commented
Oct 22, 2021
| @@ -160,10 +158,15 @@ exports.modifyService = function ( | |||
| exports.getEmptyManifest = getEmptyManifest; | |||
|
|
|||
| function sortObjectAlphabeticallyByKeys(unordered) { | |||
| if (!unordered) { | |||
| return unordered; | |||
| } | |||
There was a problem hiding this comment.
I opted to have this return the falsey value so that if your source import-map.json doesn't have scopes it doesn't get magically added be defaulting it to an empty object.
joeldenning
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a small error where one of our import-maps didn't have a "scope" property and using
alphabetical: truethrew errors. Correcting the data was enough to fix it but I thought I would be nice to also handle this better and clean up the code a bit.