Node 20 & dependencies upgrade #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilanKovacic
approved these changes
Sep 8, 2024
|
@joeldenning Thanks for fixing that. I looked into upgrading Azure Storage package as well but as soon as I did that, all tests were failing locally. So I didn't. It was a fairly big update with node 20 and I tried to make sure to look into all packages. Azure Storage didn't mention that the current version would not work with node 20 and all tests passed with the version used here. Just to give you my thought process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the import-map-deployer has a critical vulnerability (openssl:3.0.8-r3/CVE-2023-5363) by using an old node version (14).
So I upgraded to the latest LTS Node Version (20) and did some minor package updates, which also fix some vulnerabilities.
The most vulnerabilities are in
jestthough. At least 13 critical ones but upgrading that breaks the tests, so I left it for now.Also the package
requestis deprecated and needs replacing.huskyfixes (didn't run pre-commit for me)The PR addresses also following issues:
#157
#164