Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate zip_file from codebase #405

Closed
celskeggs opened this issue Sep 3, 2019 · 2 comments · Fixed by #487
Closed

Eliminate zip_file from codebase #405

celskeggs opened this issue Sep 3, 2019 · 2 comments · Fixed by #487

Comments

@celskeggs
Copy link
Member

celskeggs commented Sep 3, 2019

We're currently maintaining our own version of zip_file.bzl borrowed from an old version of Google's Nomulus repo; they are no longer maintaining this file, because they switched to Bazel, and it was never split out into a separate repository. This means a maintenance load on us to support zip files, as seen in #404.

Luckily, there's already an attempt to support a pkg_zip rule in rules_pkg: bazelbuild/rules_pkg#65. Once this gets merged, we should switch to using that instead. (And if that PR gets abandoned, we should consider whether we have the capacity to help get it finished and merged, because it'd be great to not have to maintain this ourselves.)

We no longer need to use zip_file; #487 is a demonstration of how we can eliminate this dependency.

@celskeggs
Copy link
Member Author

Upstream now supports pkg_zip, at least at a basic level.

@celskeggs
Copy link
Member Author

Unfortunately, the support available in upstream is not yet sufficient for our uses; we need more complex zip file building than they provide.

@celskeggs celskeggs mentioned this issue Feb 10, 2020
11 tasks
@celskeggs celskeggs changed the title Use zip_file from rules_pkg once supported by upstream Eliminate zip_file from codebase Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant