Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 7.4 #165

Closed
sirbrillig opened this issue Mar 25, 2020 · 4 comments
Closed

Support PHP 7.4 #165

sirbrillig opened this issue Mar 25, 2020 · 4 comments
Milestone
3.0

Comments

@sirbrillig
Copy link
Owner

This is a meta issue to make sure we support PHP 7.4 (changes)
@jrfnl
Copy link
Collaborator

jrfnl commented Mar 25, 2020

Some additions to verify if these are supported/need support:

  • If at any point the sniff looks at numbers: numeric literals with underscore separators
  • Typed properties

FYI: PHPCSUtils has helper functions which already handle PHP 7.4 correctly for each of these + arrow functions.

@sirbrillig sirbrillig mentioned this issue May 16, 2020
Merged
@kkmuffme
Copy link

Just wanted to inquire if PHP7.4 is supported now?

@sirbrillig
Copy link
Owner Author

I think the main thing we need is support for arrow functions, which I started working on in #179 but I got kind of stuck. Handling implicit closure scope turns out to be complicated. Suggestions and assistance on that PR are welcome!

@sirbrillig
Copy link
Owner Author

Closed by #179

@sirbrillig sirbrillig added this to the 3.0 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@jrfnl @sirbrillig @kkmuffme