Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to apollo-server repository #4

Open
jeromemacias opened this issue Feb 6, 2018 · 6 comments
Open

Move to apollo-server repository #4

jeromemacias opened this issue Feb 6, 2018 · 6 comments

Comments

@jeromemacias
Copy link

Should be really cool to see apollographql/apollo-server#626 fixed using this repo.

As you already done switch to TypeScript, it seems to be on the road of apollo-server-fastify ;)

Thanks for your works and @coopnd one !

@sirsavary
Copy link
Owner

There's a few small things that need to be done before I'd consider this ready for a move to apollo-server. I'll get things polished over the next few days and drop you a mention once things are good to go.

@jeromemacias
Copy link
Author

Thanks! Can I help you ?

@sirsavary
Copy link
Owner

@jeromemacias I think I'll be alright to clean the code up myself. I'm going to borrow the apollo-server-express test suite and make sure that this middleware is compliant with it. Once that's done I'll ping you and we can start migrating it into apollo-server.

@sirsavary
Copy link
Owner

@jeromemacias Just thought I'd let you know that AFAIK this plugin should now be on par with the other Apollo middlewares as of 42f18e8

@ghost
Copy link

ghost commented Mar 8, 2018

Thanks for helping out my lazy ass. This has been a long time coming....

@tomByrer
Copy link

Seems someone else is working on it the past 2 weeks if you 2 want to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants