Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umlaut/non-ascii characters broken when using bookmarklet (firefox) #148

Closed
fs111 opened this issue Aug 23, 2021 · 1 comment · Fixed by #126
Closed

umlaut/non-ascii characters broken when using bookmarklet (firefox) #148

fs111 opened this issue Aug 23, 2021 · 1 comment · Fixed by #126

Comments

@fs111
Copy link
Contributor

fs111 commented Aug 23, 2021

When I bookmark a page via the bookmarklet I get broken umlauts/other characters (like é) in the title as well as in the description. As an example:

Bookmarking https://emmikochteinfach.de/pasta-mit-kuerbis-schnell-und-einfach via the bookmarklet produces the title

"Pasta mit Kürbis - schnell und einfach gemacht - emmikochteinfach"

and description

Das einfache Rezept für Pasta mit Kürbis. Die schnellen Nudeln mit Kür...

This does not happen when using the browser plugin (for firefox).

P.S.: That pasta recipe is pretty tasty :-)

@sissbruecker
Copy link
Owner

Thanks for reporting this, it seems to be the same issue that is addressed in #126 . See this comment specifically: #126 (comment). The issue applied to all bookmarks, regardless if they were saved through the create bookmark form, the extension, or the bookmarklet. The extension just works a bit differently, in that it uses the browser tab API to show a preview for the page title.

The recipe looks tasty indeed, Guten Appetit 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants