Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Trace in console when client closes connection #37

Open
tsmortenson opened this issue Dec 9, 2019 · 0 comments
Open

Stack Trace in console when client closes connection #37

tsmortenson opened this issue Dec 9, 2019 · 0 comments

Comments

@tsmortenson
Copy link

tsmortenson commented Dec 9, 2019

We are getting large stack traces in our logs whenever a client connection is closed while the server is processing. This can easily be reproduced by simply hitting reload in the browser several times.

The stack trace starts with this:

org.eclipse.jetty.io.RuntimeIOException: org.eclipse.jetty.io.EofException
	at org.eclipse.jetty.server.ResponseWriter.isOpen(ResponseWriter.java:133)
	at org.eclipse.jetty.server.ResponseWriter.write(ResponseWriter.java:202)
	at org.apache.jasper.runtime.JspWriterImpl.flushBuffer(JspWriterImpl.java:112)
	at org.apache.jasper.runtime.JspWriterImpl.write(JspWriterImpl.java:329)
	at java.base/java.io.Writer.write(Writer.java:249)
	at com.opensymphony.module.sitemesh.parser.FastPage.writeBody(FastPage.java:48)
	at com.opensymphony.sitemesh.compatability.HTMLPage2Content.writeBody(HTMLPage2Content.java:31)
	at com.opensymphony.sitemesh.compatability.Content2HTMLPage.writeBody(Content2HTMLPage.java:44)
	at com.opensymphony.module.sitemesh.taglib.decorator.BodyTag.doEndTag(BodyTag.java:26)
...

We tracked this down to the com.opensymphony.module.sitemesh.taglib.AbstractTag class's trace method.
The com.opensymphony.module.sitemesh.taglib.decorator.BodyTag is catching the exception and then calling trace which prints the stack trace in a way which can not be disabled.

In this particular case, connections being closed is completely normal and we would really like a way to disable these messages.
We would of course want to see actual problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant