Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change with paho-mqtt release 2.0 #27

Open
isolationism opened this issue Feb 10, 2024 · 1 comment
Open

Breaking change with paho-mqtt release 2.0 #27

isolationism opened this issue Feb 10, 2024 · 1 comment

Comments

@isolationism
Copy link

Thank you for your work on this project. 🙇

Discovered this afternoon after paho-mqtt 2 was installed in a new container build.

The docs cite a new CallbackAPIVersion parameter, which corresponds with what I'm seeing in a stack trace:

   File "/usr/local/lib/python3.11/site-packages/mqttasgi/server.py", line 37, in __init__
    self.client = mqtt.Client(client_id=self.client_id, transport=self.transport, userdata={
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 TypeError: Client.__init__() missing 1 required positional argument: 'callback_api_version'
@sivulich
Copy link
Owner

Hi @isolationism, thanks for flagging this.
I see two options here. We can consider fixing the paho version or supporting both.
I'll let you know what we decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants