Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.21.0 Busybox returns the same version of v.1.20? #97

Open
luc0x61 opened this issue Dec 6, 2023 · 6 comments
Open

v1.21.0 Busybox returns the same version of v.1.20? #97

luc0x61 opened this issue Dec 6, 2023 · 6 comments

Comments

@luc0x61
Copy link

luc0x61 commented Dec 6, 2023

I just checked with v1.21.0:

 # .\busybox.exe | .\head.exe -2
BusyBox v1.37.0.git (2023-12-05 19:11:03 UTC)
(glob)

and with the previous v1.20:

 # busybox | head -2
BusyBox v1.37.0.git (2023-08-01 15:10:49 UTC)
BusyBox is copyrighted by many authors between 1998-2023.

Looks like that version number is the same, with only a change in the compilation date - and the following character encoding information, as well.
Is this right?

[EDIT] Oh well, and the Busybox calling stubs are now marked as trojan by AVG, but this is another matter... 🙄

@skeeto
Copy link
Owner

skeeto commented Dec 6, 2023

Both releases correspond to upstream BusyBox 1.37, so that's not expected to change. The (glob) is a new output corresponding to FRP-5181 (see rmyorston/busybox-w32@9e2c3594), so that's definitely the new version. (See also the discussion on 4f201b2.)

@rmyorston
Copy link

Quite by chance I've just released FRP-5236. There isn't much of any importance there.

@skeeto
Copy link
Owner

skeeto commented Dec 7, 2023

Thanks, Ron! 709f676

@rmyorston
Copy link

With FRP-5236 the w64devkit build of busybox-w32 now has a manifest which allows uname to give a sensible version on Windows 10:

~ $ 121/w64devkit/bin/uname -a
Windows_NT DESKTOP-7EEFEB9 6.2 9200 x86_64 MS/Windows
~ $ 121+/w64devkit/bin/uname -a
Windows_NT DESKTOP-7EEFEB9 10.0 19045 x86_64 MS/Windows
~ $

This was discussed in busybox-w32 issue 366.

In the README there's a link to the upsteam BusyBox man page. I have a man page on my website which is closer to the w64devkit version: BusyBox.html.

@rmyorston
Copy link

From the next release the busybox-w32 Makefile will try to use some clues to provide a more meaningful version than .git.

  • If the build is being done in a live git repository it'll use git describe.
  • Builds from my release tarballs will use an injected .frp_describe file to get the version.
  • Builds from tarballs of release tags downloaded from GitHub or GitLab will use the directory name.

Had this feature been available in earlier releases the versions reported by w64devkit would have been:

 # .\busybox.exe | .\head.exe -2
BusyBox v1.37.0.git-5181-g5c1a3b00e (2023-12-05 19:11:03 UTC)
(glob)

and

 # busybox | head -2
BusyBox v1.37.0.git-5007-g82accfc19 (2023-08-01 15:10:49 UTC)
BusyBox is copyrighted by many authors between 1998-2023.

@skeeto
Copy link
Owner

skeeto commented Feb 16, 2024

Thanks for the heads up, Ron!

rmyorston referenced this issue in rmyorston/busybox-w32 Feb 16, 2024
The default EXTRAVERSION is .git.  Use some clues to determine a
more precise EXTRAVERSION:

- git describe

- A .frp_describe file embedded in the release tarball

- The name of the build directory:  tarballs of release tags from
  GitLab and GitHub include the version in the directory name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants