Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use clap & derive for options, manpage & completions #586

Merged
merged 10 commits into from
Nov 20, 2024
Merged

feat: use clap & derive for options, manpage & completions #586

merged 10 commits into from
Nov 20, 2024

Conversation

LoricAndre
Copy link
Contributor

No description provided.

@LoricAndre LoricAndre requested a review from yazgoo November 7, 2024 20:55
@LoricAndre LoricAndre added enhancement dependencies Pull requests that update a dependency file labels Nov 7, 2024
@LoricAndre LoricAndre marked this pull request as ready for review November 8, 2024 09:33
This was referenced Nov 9, 2024
Closed
Closed
Open
@LoricAndre LoricAndre added this to the v0.11.0 milestone Nov 15, 2024
@LoricAndre LoricAndre mentioned this pull request Nov 17, 2024
Merged
yazgoo
yazgoo reviewed Nov 17, 2024
View reviewed changes
skim/src/query.rs Outdated Show resolved Hide resolved
yazgoo
yazgoo reviewed Nov 18, 2024
View reviewed changes
shell/key-bindings.zsh Outdated Show resolved Hide resolved
yazgoo
yazgoo approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@yazgoo yazgoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoricAndre LoricAndre requested a review from yazgoo November 19, 2024 16:44
@LoricAndre
Copy link
Contributor Author

@yazgoo it should be ready for review now !

@LoricAndre LoricAndre merged commit 7df8b77 into master Nov 20, 2024
5 checks passed
@LoricAndre LoricAndre deleted the feat/clap-derive branch November 20, 2024 16:01
@chenrui333 chenrui333 mentioned this pull request Nov 22, 2024
Merged
This was referenced Nov 30, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 4, 2024
Merged
Merged
@skim-rs-bot skim-rs-bot bot mentioned this pull request Dec 26, 2024
Merged
gallois added a commit to gallois/skim that referenced this pull request Dec 27, 2024
@gallois
Remove atty
4eb8c32 
This was done previously in skim-rs#587, but I suspect it was unwillingly
reintroduced in skim-rs#586. I found it while running trivy and it still
complained about an atty issue, although the project's history showed
that it has already been removed
@gallois gallois mentioned this pull request Dec 27, 2024
Merged
4 tasks
LoricAndre pushed a commit that referenced this pull request Dec 27, 2024
@gallois
fix: remove atty (#671)
b265179 
This was done previously in #587, but I suspect it was unwillingly
reintroduced in #586. I found it while running trivy and it still
complained about an atty issue, although the project's history showed
that it has already been removed
@skim-rs-bot skim-rs-bot bot mentioned this pull request Dec 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yazgoo yazgoo Awaiting requested review from yazgoo

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LoricAndre @yazgoo