Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cache Tx Decoder (backport #528) #531

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 20, 2024


This is an automatic backport of pull request #528 done by [Mergify](https://mergify.com).

* init

* nit

* nits

* nit

* more nits

* go version bump

* image bump

* nit

(cherry picked from commit bfdd584)

# Conflicts:
#	abci/checktx/check_tx_test.go
#	go.mod
#	tests/app/app.go
#	tests/e2e/go.mod
#	tests/e2e/go.sum
Copy link
Author

mergify bot commented Jun 20, 2024

Cherry-pick of bfdd584 has failed:

On branch mergify/bp/release/v1.x.x/pr-528
Your branch is up to date with 'origin/release/v1.x.x'.

You are currently cherry-picking commit bfdd584.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/lint.yml
	modified:   .github/workflows/release.yml
	modified:   .github/workflows/test.yml
	modified:   abci/checktx/mempool_parity_check_tx.go
	new file:   block/utils/decoder.go
	new file:   block/utils/decoder_test.go
	modified:   block/utils/utils.go
	modified:   contrib/images/block-sdk.e2e.Dockerfile

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   abci/checktx/check_tx_test.go
	both modified:   go.mod
	both modified:   tests/app/app.go
	both modified:   tests/e2e/go.mod
	both modified:   tests/e2e/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 20, 2024
@davidterpay
Copy link
Contributor

@mergify rebase

Copy link
Author

mergify bot commented Jun 20, 2024

rebase

☑️ Nothing to do

  • any of:
    • #commits-behind>0 [📌 rebase requirement]
    • #commits>1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.x.x@ca45053). Learn more about missing BASE report.

Files Patch % Lines
block/utils/decoder.go 96.15% 1 Missing and 1 partial ⚠️
block/utils/utils.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/v1.x.x     #531   +/-   ##
=================================================
  Coverage                  ?   42.20%           
=================================================
  Files                     ?       63           
  Lines                     ?     2779           
  Branches                  ?        0           
=================================================
  Hits                      ?     1173           
  Misses                    ?     1484           
  Partials                  ?      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay merged commit 70b5d4c into release/v1.x.x Jun 20, 2024
11 of 12 checks passed
@davidterpay davidterpay deleted the mergify/bp/release/v1.x.x/pr-528 branch June 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant