Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests in nested classes are not exercised when changing related production code not exercised by the tests' top-level class #163

Closed
pjmartos opened this issue Oct 14, 2024 · 6 comments · Fixed by #168
Assignees
Milestone

Comments

@pjmartos
Copy link

Skippy appears to not be taking into account that test classes may contain nested classes (e.g. classes annotated with @Nested) that in turn may contain test methods of their own (it is not mandatory, but it is usually the case).

Worts case scenario, if the top-level class itself doesn't exercise a production class that has changed, none of the tests would be executed, even if some of the nested classes of that test class do. The net result is that the change in the production class would be undetected.

@fmck3516
Copy link
Member

fmck3516 commented Oct 15, 2024

Thank you for your report. I was able to re-produce the issue - I'm working on a fix.

@fmck3516 fmck3516 self-assigned this Oct 15, 2024
@pjmartos
Copy link
Author

@fmck3516 I already submitted a PR with a fix: #164, would you have any suggestions?
Thanks.

@fmck3516
Copy link
Member

Thanks a bunch for the PR - I will review after work today.

@fmck3516
Copy link
Member

@fmck3516 I already submitted a PR with a fix: #164, would you have any suggestions? Thanks.

I've responded in the PR.

@fmck3516 fmck3516 linked a pull request Oct 20, 2024 that will close this issue
@fmck3516
Copy link
Member

Additional functional tests have been added in skippy-regression-suite: skippy-io/skippy-regression-suite#3

@pjmartos
Copy link
Author

Thanks @fmck3516!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants