Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkippyPlugin: Replace propagation of test failures with reasoning over test-impact-analysis.json #172

Closed
fmck3516 opened this issue Oct 31, 2024 · 0 comments · Fixed by #173
Closed

SkippyPlugin: Replace propagation of test failures with reasoning over test-impact-analysis.json #172

fmck3516 opened this issue Oct 31, 2024 · 0 comments · Fixed by #173
Assignees
@fmck3516
Labels
component: skippy-gradle type: enhancement

Comments

@fmck3516
Copy link
Member

fmck3516 commented Oct 31, 2024 •
edited
Loading

Skippy's Gradle plugin propagates test failures to all parents:

https://github.com/skippy-io/skippy/blob/f74cf756c24a398b92b1ea57ce9914d9ca41e2c3/skippy-gradle/src/main/java/io/skippy/gradle/SkippyPlugin.java#L72C21-L84C22

This should be replaced with reasoning based on the coverage data in test-impact-analysis.json. The coverage data already contains all information to infer which tests need to re-run if a nested test failed.
@fmck3516 fmck3516 self-assigned this Oct 31, 2024
@fmck3516 fmck3516 changed the title SkippyPlugin: Replace propagation of test failures with reasoning based on coverage in test-impact-analysis.json SkippyPlugin: Replace propagation of test failures with reasoning over test-impact-analysis.json Oct 31, 2024
@fmck3516 fmck3516 linked a pull request Oct 31, 2024 that will close this issue
issues/172: Replace propagation of test failures with reasoning over … #173
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmck3516 fmck3516

Labels
component: skippy-gradle type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issues/172: Replace propagation of test failures with reasoning over … skippy-io/skippy
1 participant
@fmck3516