Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Networking with custom caching solution #21

Closed
skjiisa opened this issue Feb 5, 2021 · 1 comment · Fixed by #29
Closed

Replace Networking with custom caching solution #21

skjiisa opened this issue Feb 5, 2021 · 1 comment · Fixed by #29
Milestone

Comments

@skjiisa
Copy link
Owner

skjiisa commented Feb 5, 2021

Features that would be good to have in a custom caching solution:

  • Better multi-account support for thumbnail fetching.
    • Currently, I believe if two accounts have images with the exact same path, because of the way Nextcloud handles thumbnail fetching, a cached thumbnail from one account will show up for the other account. Fixing this would be great.
  • Folder structure for disk cache for easy cleanup.
    • Currently, if an image is deleted off of the WebDAV server, the cached copy of that image will remain on-device indefinitely. Having a folder structure to the cached images would allow cached copies of deleted images to be cleaned up upon listing files.

This would come with at least some changes to the existing files and would need to be a new major version which should include a function to clear the old, now unused cache folder.

@skjiisa
Copy link
Owner Author

skjiisa commented Feb 5, 2021

Another great feature similar to the cleanup upon listing files would be to store images' etags when caching them. Then when listing files, if the etag has changed, it would know to refetch the new image.

@skjiisa skjiisa added this to the v3.0 milestone Feb 12, 2021
This was referenced Apr 16, 2021
@skjiisa skjiisa linked a pull request Apr 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant