From 7c10331fda8fd60b90a2ce728feb3069f44caa27 Mon Sep 17 00:00:00 2001 From: Adrin Jalali Date: Mon, 16 Jan 2023 12:23:01 +0100 Subject: [PATCH] Revert FIX: Persistence tests failing when using sklearn nightly (#265) Revert "FIX: Persistence tests failing when using sklearn nightly (#260)" This reverts commit 1b3c674cde51dfa853ebcf6844f10a2a9ee2cb97. --- skops/io/tests/_utils.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/skops/io/tests/_utils.py b/skops/io/tests/_utils.py index 6b02c3af..ead14b29 100644 --- a/skops/io/tests/_utils.py +++ b/skops/io/tests/_utils.py @@ -126,13 +126,6 @@ def _assert_vals_equal(val1, val2): def assert_params_equal(params1, params2): - # due to https://github.com/scikit-learn/scikit-learn/pull/22094, after - # loading an sklearn estimator, there might be an entry called - # "__sklearn_pickle_version__" in the __dict__ that wasn't there before. We - # just ignore it. - params1.pop("__sklearn_pickle_version__", None) - params2.pop("__sklearn_pickle_version__", None) - # helper function to compare estimator dictionaries of parameters assert len(params1) == len(params2) assert set(params1.keys()) == set(params2.keys())