Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrescoWebImage is cropped, no matter what ContentScale type is used #502

Closed
MiniEmerald opened this issue Jun 19, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@MiniEmerald
Copy link

Hi, I encountered an issue with the library.

Please complete the following information:

  • Library Version
    com.github.skydoves:landscapist-fresco v2.3.4
    com.github.skydoves:landscapist-fresco-websupport v2.3.4

  • Affected Device(s)
    All? (Tested on the Android Studio Emulator from API 24 to 35/VanillaIceCream, on a tablet, and on a phone)

Describe the Bug:

Content of a FrescoWebImage is cropped, no matter what ContentScale type is passed to the FrescoWebImage

Happens for both still and animated images

Expected Behavior:

FrescoWebImage image scaling behaves according to the ContentScale used

Example with screenshot

val url = "https://download.blender.org/branding/blender_logo_socket.png"

FrescoWebImage(
    controllerBuilder = {
        Fresco.newDraweeControllerBuilder().setUri(url)
    },
    contentScale = ContentScale.Fit,
    modifier = Modifier.fillMaxWidth()
)

Screenshot_20240619_231151

@skydoves
Copy link
Owner

Hey @MiniEmerald, thank you for reporting this issue. It has been fixed on the new release, 2.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants