From 654ed4a2b7623693be5c2a1b9cfc44348f275463 Mon Sep 17 00:00:00 2001 From: Cody Brownstein <105375373+cbrownstein-lambda@users.noreply.github.com> Date: Wed, 6 Nov 2024 14:30:08 -0800 Subject: [PATCH] Update comments pointing to Lambda's docs (#4272) --- sky/provision/lambda_cloud/lambda_utils.py | 4 ++-- sky/skylet/providers/scp/node_provider.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sky/provision/lambda_cloud/lambda_utils.py b/sky/provision/lambda_cloud/lambda_utils.py index 339919e80e7..4d8e6246b6d 100644 --- a/sky/provision/lambda_cloud/lambda_utils.py +++ b/sky/provision/lambda_cloud/lambda_utils.py @@ -82,7 +82,7 @@ def raise_lambda_error(response: requests.Response) -> None: if status_code == 200: return if status_code == 429: - # https://docs.lambdalabs.com/cloud/rate-limiting/ + # https://docs.lambdalabs.com/public-cloud/cloud-api/ raise LambdaCloudError('Your API requests are being rate limited.') try: resp_json = response.json() @@ -145,7 +145,7 @@ def create_instances( # Most API requests are rate limited at ~1 request every second but # launch requests are rate limited at ~1 request every 10 seconds. # So don't use launch requests to check availability. - # See https://docs.lambdalabs.com/cloud/rate-limiting/ for more. + # See https://docs.lambdalabs.com/public-cloud/cloud-api/ for more. available_regions = (self.list_catalog()[instance_type] ['regions_with_capacity_available']) available_regions = [reg['name'] for reg in available_regions] diff --git a/sky/skylet/providers/scp/node_provider.py b/sky/skylet/providers/scp/node_provider.py index 955bb0f8e19..004eaac3830 100644 --- a/sky/skylet/providers/scp/node_provider.py +++ b/sky/skylet/providers/scp/node_provider.py @@ -180,7 +180,7 @@ def _extract_metadata(self, vm: Dict[str, Any]) -> Dict[str, Any]: metadata['tags'] = instance_info['tags'] # TODO(ewzeng): The internal ip is hard to get, so set it to the # external ip as a hack. This should be changed in the future. - # https://docs.lambdalabs.com/cloud/learn-private-ip-address/ + # https://docs.lambdalabs.com/public-cloud/on-demand/getting-started/#learn-your-instances-private-ip-address metadata['internal_ip'] = vm['ip'] metadata['external_ip'] = vm['external_ip'] return metadata