Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speclite 0.13 incompatible with Astropy 4.3.x #482

Closed
2 tasks done
rrjbca opened this issue Sep 1, 2021 · 0 comments · Fixed by #486
Closed
2 tasks done

Speclite 0.13 incompatible with Astropy 4.3.x #482

rrjbca opened this issue Sep 1, 2021 · 0 comments · Fixed by #486
Assignees
Labels
high priority issues needing immediate attention infrastructure

Comments

@rrjbca
Copy link
Contributor

rrjbca commented Sep 1, 2021

With astropy 4.3 the function _find_pkg_data_path was renamed to get_pkg_data_path. Speclite 0.13 uses the old function name and is therefore incompatible with astropy>=4.3. There is a fix for this on the speclite develop branch but this patch has not yet been incorporated into a release. Critically, this incompatibility causes our readthedocs builds to fail and in turn blocks our CI checks. This requires a two stage fix...

  • Temporarily fix astropy >=4.0, <4.3 to resolve the readthedocs failures and unblock our CI checks
  • After speclite 0.14 is released revert to astropy>=4 and fix speclite>=0.14

To Reproduce

  1. pip install astropy==4.3.1 speclite==0.13
  2. git clone https://github.com/skypy/skypy.git
  3. cd skypy/docs
  4. make html
WARNING: examples/galaxies/plot_photometry.py failed to execute correctly: Traceback (most recent call last): 
  File "examples/galaxies/plot_photometry.py", line 65, in <module>
    pipeline.execute()
  File "skypy/pipeline/_pipeline.py", line 191, in execute
    self.state[table][column] = self.evaluate(settings)
  File "skypy/pipeline/_pipeline.py", line 264, in evaluate
    return value.evaluate(self)
  File "skypy/pipeline/_items.py", line 93, in evaluate
    return self.function(*args, **kwargs)
  File "skypy/galaxies/spectrum.py", line 143, in stellar_mass
    Mt = self.absolute_magnitudes(coefficients, filter)
  File "skypy/utils/photometry.py", line 191, in absolute_magnitudes
    M = mag_ab(self.wavelength, self.templates, filters, coefficients=coefficients)
  File "skypy/utils/photometry.py", line 92, in mag_ab
    filters = load_filters(*filters)
  File "speclite/filters.py", line 1807, in load_filters
    filters_path = astropy.utils.data._find_pkg_data_path('data/filters/')
AttributeError: module 'astropy.utils.data' has no attribute '_find_pkg_data_path'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority issues needing immediate attention infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant