Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: attachments persist through edited command replies #166

Open
ghost opened this issue Sep 2, 2022 · 4 comments
Open

bug: attachments persist through edited command replies #166

ghost opened this issue Sep 2, 2022 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented Sep 2, 2022

Describe the bug

After editing the command which produces attachments to another command which does not produce attachments, attachments appear in new command reply.

To Reproduce

  1. Use a command which produces a message with attachment.
  2. Edit command to another command which produces a message with plain text.
  3. Observe the first commands attachment appearing beside plain text message.

Expected behavior

Second command does not contain elements from first command results.

@ghost ghost changed the title bug: bug: attachments persist through edited command replies Sep 2, 2022
@favna
Copy link
Member

favna commented Sep 2, 2022

Please provide your exact code as well as version of the package that you're using because this bug should've been fixed a while ago

@ghost
Copy link
Author

ghost commented Sep 2, 2022

Using @skyra/editable-commands@2.1.4

@favna
Copy link
Member

favna commented Sep 2, 2022

And also please provide the exact code used as requested

@ghost
Copy link
Author

ghost commented Sep 2, 2022

As for code, the problem is appearing all over my commands and I dont want to share full files or repository

Command 1 is using:
send(message, { embeds: [someEmbed], files: [someAttachment] });
Command 2 is using:
send(message, { content: someText });

Result: after editing Command1 -> Command2 users see someText with someAttchment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants