-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth_estimateGas is not supplied the gasPrice parameter #118
Comments
We have temporarily lowered the refund threshold in order to alleviate the issue. The lower gasPrice to test with is now 1 wei. You can also use the contract at 0x28a958cD020efeA3734a0bb36DDdc5F9B872cEa8 to test your estimateGas fix. |
@wjmelements Great point. I’ve totally forgot it when was making the original implementation. @BaldyAsh can you quickly fix this? |
@wjmelements hi! Think I've fixed it, but need some tusd for test . Could you provide some? If yes, then my address: 0x4fd693F57e63714591A07A73A4D7AD84e5cCdE10 |
@wjmelements Tested on contract you've posted to this discussion. Closed by #199. |
Because Ethereum transactions can call the
GASPRICE
opcode (3a
) and branch on it,eth_estimateGas
without agasPrice
parameter can return inaccurate results. Transactions that do not supply enough gasLimit will revert.You can test this by estimating gas on a TrueUSD transfer. The gasLimit required is approximately 21k higher for a 40 gwei tx than for a 1 wei tx.
A discussion of this issue for another project is here.
TrueUSD is the rank 4 ERC20 token by market cap. Please prioritize this issue so your users can use TrueUSD.
The text was updated successfully, but these errors were encountered: