Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new wallet is too slow #532

Closed
xhzth70911 opened this issue Apr 19, 2022 · 6 comments
Closed

Creating a new wallet is too slow #532

xhzth70911 opened this issue Apr 19, 2022 · 6 comments
Labels
FAQ common questions tend to recur about web3 infra

Comments

@xhzth70911
Copy link

xhzth70911 commented Apr 19, 2022

macos Version :12.3
xcode Version : 13.3
cocospod Version:1.11.3
Installing BigInt (5.2.0)
Installing CryptoSwift (1.4.3)
Installing PromiseKit (6.15.3)
Installing Starscream (4.0.4)
Installing secp256k1.c (0.1.2)
Installing web3swift (2.6.0)
6870A674-EB41-4487-A38F-EA2E61FDFA79

Creating a new wallet is too slow, 5 seconds to print information
E2E3812F-C162-468C-B004-0D1AD1F0F015

4F6F0A41-79A1-4E9B-9D12-E16F25DB473E

Get private key is too slow,5 seconds to print information
The speed of creating wallet in web3swift version 2.3.0 is normal

@mloit
Copy link
Contributor

mloit commented Apr 19, 2022

This has been on my radar for a while. Now that EIP-1559 support is out I'll start looking into it now.

@mloit
Copy link
Contributor

mloit commented Apr 19, 2022

What hardware are you building/testing on? Also can you try building in release mode to see if this solves the problem?

@xhzth70911
Copy link
Author

你正在制造/测试什么硬件?

iphone6 plus

@mloit
Copy link
Contributor

mloit commented Apr 20, 2022

Can you please build your code in "release" mode, and report back if the issue is still present then?

@RaviRanjan-11
Copy link
Contributor

Please let me know if this exist in Real device as well

@mloit
Copy link
Contributor

mloit commented Apr 28, 2022

I can confirm that the issue lies between debug and release builds. I created a simple test app to create a private key.

Debug Build/Run: 7.790989995002747
Release Build/Run: 0.10214793682098389

The issue is also exclusively when building via SPM, as SPM builds everything from source, using the app's build settings. XCode projects include the libraries as frameworks, which are built separately in release mode, so even a debug app, does not see the same performance hit.

This not really an issue as it affects debugging only, and there is nothing we can really do about it. This is a known issue with CryptoSwift, you can follow the link posted in #535 if you want to know more.

This issue should probably be closed at this point.

@Kristenlike1234 Kristenlike1234 added the FAQ common questions tend to recur about web3 infra label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FAQ common questions tend to recur about web3 infra
Projects
None yet
Development

No branches or pull requests

4 participants