Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding description string to Web3Error #1

Merged

Conversation

GabCas
Copy link

@GabCas GabCas commented Aug 14, 2018

Hi Alex,

from issue: BANKEX/web3swift#194

I've added a String description to the Web3Error enum in Web3.swift. Then modified whenever an error was created that required the description.

@shamatar shamatar self-assigned this Aug 21, 2018
@shamatar
Copy link
Contributor

Hello @GabCas

You I like your idea with better descriptions for errors, although can you try to make them more informative? Probably with some hint what user should do to try to fix it?

Sincerely, Alex

@GabCas
Copy link
Author

GabCas commented Aug 23, 2018

Hi Alex,

for inputError, nodeError and processingError I'm attaching the same error description that you were logging which are very descriptive error messages so the user can know what to do to fix them. These in particular are the error messages I want to show the user instead of a generic error like "web3swift.Web3Error error 1."

Do you have in mind a specific error that requires a more detailed description?

Thanks!

@shamatar
Copy link
Contributor

Hello @GabCas

I'll fix descriptions when it's possible by myself. I think most valuable for users would be either "missing parameter" or "transaction is likely to revert".

@shamatar shamatar merged commit 71f54d0 into web3swift-team:develop Aug 25, 2018
@ghost ghost mentioned this pull request Jun 12, 2021
BaldyAsh pushed a commit that referenced this pull request Oct 29, 2021
yaroslavyaroslav pushed a commit that referenced this pull request May 5, 2022
megakoko referenced this pull request in tangem/web3swift Jun 15, 2022
…send-screen-with-11111111111111111111111111111111-in-the-clipboard

Updated Base58.swift from https://github.com/skywinder/web3swift/pull/504/commits
yaroslavyaroslav pushed a commit that referenced this pull request Jul 19, 2023
- Generation amount of addresses added
- Generation wallet with index > 9 fixed
- Test generation addresses added
yaroslavyaroslav pushed a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants