-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[recreated] Detect read function aborting by messaged require statement #276
[recreated] Detect read function aborting by messaged require statement #276
Conversation
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 33.0 DAI (33.0 USD @ $1.0/DAI) attached to it.
|
Thank you very much! Great addition! And thank for represent test cases as well! As final addition before merge, I would like to setup test of feature on rinkeby network. |
Thank you for your reply. |
@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot I received acceptance notification about 3 hours ago. Please I am on it .. I would update in 24 hours time. |
@janus would you like to add test as @hakumai-iida described above? is so, i will create separate bounty for that. (this bount reserved for @hakumai-iida (please, apply for this task in https://gitcoin.co/issue/matter-labs/web3swift/276/100023790) |
@skywinder Okay .. I would do as per your instruction |
Sorry for the my late action. And, i tried to apply it, but it failed with the following error. |
No worries @hakumai-iida no it should be fine please try again and feel free to contact me by email if you need any support. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 265 years, 10 months from now. 1) hakumai-iida has been approved to start work. From github I checked the operation in the rinkeby test net, and the check completed successfully. Learn more on the Gitcoin Issue Details page. |
dear @hakumai-iida , Happy new year! 🎉 |
@janus |
Thanks. Let me have the url of the bounty. |
@janus there is no URL (yet). you have to create an issue and I will link bounty to it. 👍 |
Okay |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 64.0 DAI (64.0 USD @ $1.0/DAI) has been submitted by:
|
dear @skywinder I am glad the pull request merged without problems. Thank you for the double bounty! |
[Reposted because the repository was recreated]
Dear all:
If a require statement with a message aborts the reading function, an unexpected value may be returned as a response.
For example, if you call the following function,
The following response will be returned.
If the reading function is aborted by a require statement that has a message, it seems that the data with the following configuration will be returned.(By the way, if there is no message specified in the require statement, [0] bytes will be returned as a response, so require could not be detected.)
Since it is helpful to know whether the reading function was aborted by require statement, I made a simple correction and sent the pull request.
please confirm.
If you call the above sample function with the modified code, empty data will be returned with the following log
Also, I have confirmed the operation by checking the operation with the following contract.
Then, thank you for the above.