R1.7.3 #69
Merged
R1.7.3 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JJL772
commented
Jul 22, 2024
JJL772
commented
- CI Improvements (CI maintinence and more clang-tidy checks #66)
- Using Ubuntu 22.04 now
- Expand list of clang-tidy checks
- Fix signedness handling for EL3XXX and EL4XXX terminals #67
- Improvements for bipolar analog input and output terminals. Absolute value w/MSB sign still unsupported.
- Update asyn to R4.39-1.0.2 and modbus to R3.2-1.0.2 #68
Bunch of new clang-tidy checks, mostly a subset of bugprone- and misc-. Also added annotations explaining why these are necessary. .clang-tidy now supports a list syntax in clang 17. To retain backwards compatibility with older versions of clang-tidy, the script will automatically convert the config to a JSON and passes that to clang-tidy directly.
Both signed and unsigned representations behave like a signed 16-bit integer. In the case of unsigned, the value is limited to the range 0-32767, the former is limited to -32768-32767. As such, treating the values from the terminal as int16 (and thus sign extending them when assigning to RVAL) is the correct way of doing things. This does not handle the MSB representation properly however. That will require more work down the line if we ever decide to support it. For now, users will need to use the unsigned or signed representations for the data to be correctly read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.