Fix: rewind body before reading it.

slack-ruby · Jan 31, 2024 · 67b60b4 · 67b60b4
1 parent 015f615
commit 67b60b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/slack/events/request.rb b/lib/slack/events/request.rb
@@ -38,8 +38,10 @@ def version
       # Request body.
       def body
         @body ||= begin
-          body = http_request.body.read
-          http_request.body.rewind
+          input = http_request.body
+          input.rewind
+          body = input.read
+          input.rewind
           body
         end
       end

diff --git a/spec/slack/events/request_spec.rb b/spec/slack/events/request_spec.rb
@@ -47,6 +47,17 @@
     expect(http_request.body.read).to eq body
   end
 
+  context 'with an already read body' do
+    before do
+      http_request.body.read
+    end
+
+    it 'rewinds the request body before reading it' do
+      expect(request.body).to eq body
+      expect(http_request.body.read).to eq body
+    end
+  end
+
   context 'time' do
     after do
       Timecop.return