-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add websocket-level ping monitoring #223
Comments
@dblock How are you going with this? I am back in NZ and can take a look at it if you still require assistance. |
I am not doing any work rn with this. The replacement of celluloid with async has shipped, but did nothing to improve the underlying problem. |
I started to take a look at this last Friday and I believe I'll have a PR ready for review in a few hours. I'd welcome any feedback and guidance on it! |
Implemented for async-websocket in #226. |
Implemented for Celluloid and EM in #236. |
Ping monitoring in slack-ruby-bot-server checks status of the bot, but faye/websocket-driver-ruby#61 (comment) is saying that we could be sending a ping at websocket level. Which should cause the next read to return a
nil
and abort an offline situation.The text was updated successfully, but these errors were encountered: