Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attachments support for Slack::Web::Api::Endpoints::Chat.chat_update #69

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Add attachments support for Slack::Web::Api::Endpoints::Chat.chat_update #69

merged 1 commit into from
Mar 10, 2016

Conversation

nicka
Copy link
Contributor

@nicka nicka commented Mar 9, 2016

No description provided.

@dblock
Copy link
Collaborator

dblock commented Mar 9, 2016

Unfortunately this is not as easy :) This file is generated by a Rake task from documentation. If slack has documented this, the first step is to update https://github.com/dblock/slack-api-ref. Then in this project you can run rake slack:api:update. Everything on top is a patch, you can see how it's done for chat_postMessage in https://github.com/dblock/slack-ruby-client/tree/master/lib/slack/web/api/patches. The specs should be good though.

Also will need a CHANGELOG entry, please.

@nicka
Copy link
Contributor Author

nicka commented Mar 9, 2016

@dblock Sure thing, will fix it. Do you also want me to do a version bump? Or something like Next version within the CHANGELOG.md?

@nicka
Copy link
Contributor Author

nicka commented Mar 9, 2016

@dblock Added the patch 👍 and updated the CHANGELOG.md.

dblock
dblock reviewed Mar 10, 2016
View reviewed changes
CHANGELOG.md
@@ -1,6 +1,6 @@
### 0.7.1 (Next)

* Your contribution here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this back please?

@dblock
Copy link
Collaborator

dblock commented Mar 10, 2016

Would have merged minus my removed line in CHANGELOG. Looking forward to an --amend. Thanks!

@nicka
Copy link
Contributor Author

nicka commented Mar 10, 2016

@dblock Done!

dblock added a commit that referenced this pull request Mar 10, 2016
@dblock
Merge pull request #69 from nicka/master
fcfe9b2 
Add attachments support for Slack::Web::Api::Endpoints::Chat.chat_update
@dblock dblock merged commit fcfe9b2 into slack-ruby:master Mar 10, 2016
@dblock
Copy link
Collaborator

dblock commented Mar 10, 2016

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicka @dblock