Addressing a few issues with #run_ping! (Fixes #231) #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several issues with the initial implementation (#226) of
Slack::RealTime::Client#run_ping!
; a method which is responsible for ensuring theSlack::RealTime::Client
stays connected untilSlack::RealTime::Client#stop!
is called.Slack::RealTime::Client#close
will no longer assign nil to@socket
because the reactor would still be running in the background ifwebsocket_ping
is set.Slack::RealTime::Concurrency::Async::Socket#disconnect!
now cancels all timers (via@reactor.cancel
). This shuts down thewebsocket_ping
timer.Slack::RealTime::Client#run_ping!
and now use on the builtin functionAsync::Reactor#every
to run the ping on an interval.Slack::RealTime::Client#restart_sync
which is responsible for obtaining a new websocket url and attempting to connect to it.Slack::RealTime::Client#stop!
; on the nextSlack::RealTime::Client#run_ping!
we'll attempt to restart the connection (viaSlack::RealTime::Client#restart_sync
)Slack::RealTime::Client#restart_async
), we reraiseSlack::RealTime::Client::ClientNotStartedError
Requirements