Support rack requests in Slack::Events::Request #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#headers` method on a request is implemented by Rails, so in order for the event request class to support other rack based servers we can instead look for the headers via `#get_header` or `#env`. Since Rail's requests are an extension of rack requests this will also work in a Rails app.
wedgex
force-pushed
the
support-rack-requests
branch
from
35e8d57 to
015b389
Compare
wedgex
force-pushed
the
support-rack-requests
branch
from
015b389 to
6b27461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#headersmethod on a request is implemented by Rails, so inorder for the event request class to support other rack based servers
we can instead look for the headers via
#get_headeror#env.Since Rail's requests are an extension of rack requests this will
also work in a Rails app.
Also worth noting that rack's header's are prepended with
HTTP_,upcased, and treats
-and_both as a_. Rails has some logic toobfuscate this but technically supports both.