Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "events" in the document even clearer #1013

Closed
4 of 10 tasks
seratch opened this issue Jul 20, 2021 · 3 comments · Fixed by #1046
Closed
4 of 10 tasks

Make "events" in the document even clearer #1013

seratch opened this issue Jul 20, 2021 · 3 comments · Fixed by #1046
Labels
docs M-T: Documentation work only good first issue Good for newcomers
Milestone

Comments

@seratch
Copy link
Member

seratch commented Jul 20, 2021

Description

Currently, we are using the term "event" for both Events API data and any incoming payload requests from Slack in the Bolt document. For example,

This can be confusing for developers especially when they are not yet familiar with the Slack Platform yet.

To improve this, we can consistently use the term "request" for incoming requests from Slack. Specifically,

  • We can rename the section "Acknowledging events" to "Acknowledging requests"
  • We can replace all the phrases like "acknowledging events" to "acknowledge requests" in all sections

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added docs M-T: Documentation work only good first issue Good for newcomers labels Jul 20, 2021
@seratch seratch added this to the 3.6.0 milestone Jul 20, 2021
@RhnSharma
Copy link
Contributor

I would like to take this one.

@seratch
Copy link
Member Author

seratch commented Jul 21, 2021

@RhnSharma Thanks for your interest! Before starting to work on this repo, let's finish the pull request for bolt-python slackapi/bolt-python#415

@seratch seratch modified the milestones: 3.6.0, 3.x Aug 6, 2021
@seratch
Copy link
Member Author

seratch commented Aug 7, 2021

slackapi/bolt-python#415 has been merged. Contributors can apply the same changes to this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants