Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secureli-release-noop step in pipeline #391

Open
tdurk93 opened this issue Jan 19, 2024 · 0 comments
Open

Fix secureli-release-noop step in pipeline #391

tdurk93 opened this issue Jan 19, 2024 · 0 comments
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@tdurk93
Copy link
Contributor

tdurk93 commented Jan 19, 2024

As a SeCurLI user, I want SeCurLI to simulate the behavior as if it were running in the main branch. 
 
So that we can correct our semantic-release dry-run step HERE to serve as a valid test.
 
Currently, because SeCurLI  is ran on PR branches, it always exits with the following message:
 
branch '' isn't in any
release groups; no release will be made
 
We need to figure out how to make SeCurLI simulate the behavior as if it were running in the main branch  which could require fixing the release group to include all branches. 
 
 
AC:
-              SeCurLI simulates the behavior of running on the main branch
-              Semantic-release dry-run is served as a valid test
 
Open Questions:
-              Why does this step use the github action relekang/python-semantic-release instead of python-semantic-release/python-semantic-release, which is what we use in the actual release? We may need to swap that test is using the same Action as the actual release.

@tdurk93 tdurk93 added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Jan 19, 2024
@blonienc blonienc added the testing Bulk of this work is writing or updating unit/smoke tests label Apr 1, 2024
@blonienc blonienc removed the testing Bulk of this work is writing or updating unit/smoke tests label Apr 12, 2024
@shrutitirpude shrutitirpude self-assigned this Jun 25, 2024
@shrutitirpude shrutitirpude removed their assignment Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
Status: Todo
Development

No branches or pull requests

3 participants