Newsfeed issue/PR label events aren't handled

[kashav]

Think this is caused by Newsfeed API changes (#773).

Here's the event on the GitHub homepage:

and in app:

[maniac103]

So the issue seems to be that EventAdapter doesn't generate a title for label events. Doesn't seem to be related to the news feed changes, but it's a bug nevertheless :-)

[maniac103]

Actually, this seems to be a (temporary?) server side bug. According to the docs, label events should not appear in timelines, and this seems to be the case for me as of now. @kshvmdn Can you still see such events in your timeline?

[kashav]

@maniac103, seems to still be the case for me, saw this one yesterday (unless this was patched within the last 20 hours?):

[kashav]

Now that I'm thinking about it, I'm watching a ton of repos where issues are being labelled (including this one), but this problem only occurs for that single repo (golang/dep).

Edit: furthermore it only happens for specific labels (help wanted and good first issue from what I can tell). Note that this issue was created and labelled after the one in the screenshot above, but I didn't see any label events on my newsfeed for this one.

[devdrops]

Now that I'm thinking about it, I'm watching a ton of repos where issues are being labelled (including this one), but this problem only occurs for that single repo (golang/dep).

@kshvmdn I noticed this behavior on other repositories too (https://github.com/LappleApple/feedmereadmes):

[kashav]

@devdrops, ah, interesting. I noticed that each of those issues has the "good first issue" label, which might be the problem here.

@maniac103, you think you can test this with that issue specifically?

[maniac103]

you think you can test this with that issue specifically?

Problem is that I don't have access to your timelines :-( Those events don't appear in the respective repository timelines (repo activity tab); I just tried with that feedmereadmes repo.

Just to make it clear: the app currently doesn't handle those events because they're not supposed to be present at all.

I also asked Github support about it; they said it's likely not intentional and they'll investigate.

[kashav]

Just to make it clear: the app currently doesn't handle those events because they're not supposed to be present at all.

Haha, yeah, that's what I meant when I said this was caused by changes to the newsfeed API.

I guess the best solution for the time being is to just wait for GitHub to solve the API problems.

[maniac103]

@kshvmdn Is this fixed (by Github's latest changes to the news feed API) now?

[kashav]

@maniac103, I think so, haven't seen this happen again since the API was fixed. Will reopen if I see anything.