I added another commit to fix a test failure on AppVeyor.

On Windows, you just need to install tzdata to use zoneinfo and no extra imports are needed.

Thanks @mobinghoveoud!

I'm wondering if it's easier to convert the data to python's datetime and let python module compare the dates!

I'm wondering if it's easier to convert the data to python's datetime and let python module compare the dates!

Thanks for reply @slashmili .
I considered this approach but there may be some performance concerns with too many comparisons. Commonly, we’re comparing two jdatetime instances, so each comparison requires two conversions. Letting python's datetime module handle the comparisons would certainly make implementation easier.

If performance is a priority, the current method works well but if easier implementation and maintenance are more important, the conversion approach could be a feasible alternative. I agree with both approaches.

Thanks @slashmili for asking my opinion here.

The change LGTM 👍

I agree with @mobinghoveoud that the current implementation has better performance, but the data-time approach needs less maintenance effort in the future. It's up to you, @slashmili, to decide.

Sorry for @mobinghoveoud for getting to you late. I'd prefer to not keep the logic and rely on python datetime. I'd say speed of comparison has lower priority compare to maintainability of this project.

Thanks, I'll try this approach.

To compare the datetimes, first converted to python datetime objects.

• For equality __eq__, the locales are checked first. If they are different, it returns False.
• The __ne__ method was removed since it already relies on __eq__.
• Tests have been updated.