-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slim 1.40.9 not compatible with new release docker 25.0 #632
Comments
@eli-yip thank you for the report! investigating... |
The issue appears to be limited in certain environments. Doesn't manifest itself everywhere. Still investigating... |
Now with slim 1.40.10 (latest stable version) and docker 25.0, I tried to slim --debug build --tag test:1.0 --http-probe=false --pull --target alpine:3.19 Result:
Whole output in my terminal:
{
"version": "1.1",
"engine": "linux/amd64|Transformer|1.40.10|b04d388ded5cc50e89c532604b63cc2c0966f5cf|2024-01-18_04:11:02AM",
"containerized": false,
"host_distro": {
"name": "Ubuntu",
"version": "22.04",
"display_name": "Ubuntu 22.04.3 LTS"
},
"type": "build",
"state": "error",
"target_reference": "alpine:3.19",
"system": {
"type": "",
"release": "",
"distro": {
"name": "",
"version": "",
"display_name": ""
}
},
"source_image": {
"identity": {
"id": ""
},
"size": 0,
"size_human": "",
"create_time": "",
"docker_version": "",
"architecture": "",
"container_entry": {
"exe_path": ""
}
},
"minified_image_size": 0,
"minified_image_size_human": "",
"minified_image": "",
"minified_image_has_data": false,
"minified_by": 0,
"artifact_location": "",
"container_report_name": "",
"seccomp_profile_name": "",
"apparmor_profile_name": "",
"image_stack": null,
"image_created": false,
"image_build_engine": ""
} My docker version:
|
thank you for sharing the logs @eli-yip ... investigating |
@eli-yip note that you are trying to minify a base image, |
finally managed to reproduce it and there's a fix for it (will be available in the next release) |
@kcq thank you!!! |
Thank you for the reminder. I am using the alpine image here to confirm whether the issue is due to compatibility between To ensure that I've understood you correctly, let me clarify: Even for testing purposes, I should not use a base image, as this would cause errors with |
@eli-yip it's ok to use a vanilla base image if it's for testing purposes. Just wanted to make sure you are aware of what you'll get there. I also recommend picking a simple shell command with that vanilla base image, so the minified version would have that command and you can see that the minified image works (for that shell command you picked). Example: Then you should be able to use the minified image like this: |
Thank you |
Docker Engine v25.x broke other things too... waiting for the upstream dependency maintainers to have a fix |
getting close... will update in a couple of days |
new release, should support Docker Engine 25.x: https://github.com/slimtoolkit/slim/releases/tag/1.40.11 |
Works fine, thank you so much. |
I'm actually still seeing this issue on OSX:
|
Update: Downgrading from API version
|
@paulcalabro With that release you might need to adjust the docker API explicitly, but the latest version shouldn't require it. I couldn't repro the failure with it. |
Expected Behavior
slim optimize docker image
Actual Behavior
throw an error tell me my docker engine api version is too low, which is not the case at all.
But when I downgrade my docker version to 24.0.7, it works fine again.
My system is ubuntu 22.04.
The text was updated successfully, but these errors were encountered: