Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add a release URL to builders and generators for uploading assets #710

Closed
asraa opened this issue Aug 12, 2022 · 9 comments · Fixed by #713
Closed

[feature] Add a release URL to builders and generators for uploading assets #710

asraa opened this issue Aug 12, 2022 · 9 comments · Fixed by #713
Labels
area:generic Issue with the generic generator github_actions Pull requests that update GitHub Actions code good first issue Good issue for first time contributors. status:help wanted Extra attention is needed type:feature New feature or request

Comments

@asraa
Copy link
Collaborator

asraa commented Aug 12, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
For some workflow triggers like workflow_dispatch, the github.ref does not indicate the release URL. We should expose an option like

          upload_url: ${{ steps.create-release.outputs.upload_url }}

that can be used to indicate the release URL to upload assets to.

That would simplify the workflow, and reduce the amount of friction for users. Otherwise, they need to specify their own upload, or manually upload the artifact themselves.

See GoogleContainerTools/jib@e85d34e

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@asraa asraa added type:feature New feature or request status:triage Issue that has not been triaged status:good first issue github_actions Pull requests that update GitHub Actions code and removed status:triage Issue that has not been triaged labels Aug 12, 2022
@asraa asraa added this to the GA for generic generator milestone Aug 12, 2022
@laurentsimon
Copy link
Collaborator

laurentsimon commented Aug 12, 2022

Repositories to update:

@laurentsimon
Copy link
Collaborator

We also need e2e tests for this.

@laurentsimon
Copy link
Collaborator

See this PR which has the code to use: https://github.com/GoogleContainerTools/jib/pull/3726/files

@ianlewis
Copy link
Member

See this PR which has the code to use: https://github.com/GoogleContainerTools/jib/pull/3726/files

This PR uses actions/upload-release-asset which isn't maintained anymore in favor of softprops/action-gh-release which is the action we use. Maybe the right input we need use is tag_name?
https://github.com/softprops/action-gh-release#inputs

@laurentsimon
Copy link
Collaborator

laurentsimon commented Aug 25, 2022

you're correct. Note that I only re-used the GHA they already use in their code (https://github.com/GoogleContainerTools/jib/blob/master/.github/workflows/jib-cli-release.yml#L82), it's not something I asked them to use.

I've created #713 to own the code for us internally, and maybe other repos could use it?

@hazcod
Copy link

hazcod commented Dec 2, 2022

Can you mention here what release it'll end up in @laurentsimon ? Thanks!

@laurentsimon
Copy link
Collaborator

Should be part of the [2022 Stability improvements](https://github.com/slsa-framework/slsa-github-generator/milestone/6). Thanks for the interest! Which project do you want to use it for?

@laurentsimon
Copy link
Collaborator

This PR needs to be landed #1307

@hazcod
Copy link

hazcod commented Dec 3, 2022

Should be part of the [2022 Stability improvements](https://github.com/slsa-framework/slsa-github-generator/milestone/6). Thanks for the interest! Which project do you want to use it for?

Thanks! I'm writing an SDK for the API on Intigriti and want to ensure we do all of our due diligence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:generic Issue with the generic generator github_actions Pull requests that update GitHub Actions code good first issue Good issue for first time contributors. status:help wanted Extra attention is needed type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants