-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add a release URL to builders and generators for uploading assets #710
Comments
Repositories to update: |
We also need e2e tests for this. |
See this PR which has the code to use: https://github.com/GoogleContainerTools/jib/pull/3726/files |
This PR uses |
you're correct. Note that I only re-used the GHA they already use in their code (https://github.com/GoogleContainerTools/jib/blob/master/.github/workflows/jib-cli-release.yml#L82), it's not something I asked them to use. I've created #713 to own the code for us internally, and maybe other repos could use it? |
Can you mention here what release it'll end up in @laurentsimon ? Thanks! |
Should be part of the |
This PR needs to be landed #1307 |
Thanks! I'm writing an SDK for the API on Intigriti and want to ensure we do all of our due diligence. |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
For some workflow triggers like
workflow_dispatch
, thegithub.ref
does not indicate the release URL. We should expose an option likethat can be used to indicate the release URL to upload assets to.
That would simplify the workflow, and reduce the amount of friction for users. Otherwise, they need to specify their own upload, or manually upload the artifact themselves.
See GoogleContainerTools/jib@e85d34e
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: