chore: re-enable ruff F811 and fix violations #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2968 +/- ##
=======================================
Coverage 54.58% 54.59%
=======================================
Files 90 90
Lines 12900 12899 -1
=======================================
Hits 7042 7042
+ Misses 5858 5857 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
connortann
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F811 ruff rule is "Redefinition of unused variable".
One thing to note is that
_maple.pyis a piece of vendored code, so I've opted to exclude ruff linting for it (to avoid making changes to it).