Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ntree_limit deprecation warning in _tree.py #2987

Merged
merged 4 commits into from
Jun 14, 2023
Merged

fix ntree_limit deprecation warning in _tree.py #2987

merged 4 commits into from
Jun 14, 2023

Conversation

adnene-guessoum
Copy link
Contributor

@adnene-guessoum adnene-guessoum commented Jun 13, 2023

Overview

Description of the changes proposed in this pull request:

Related to issue #2984 (comment) .

fixes the deprecation warning mentionned in the issue by using iteration_range instead of ntree_limit as advised by xgboost documentation since version 1.4 ( https://github.com/dmlc/xgboost/releases/tag/v1.4.0 ).

Checklist

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2987 (9b6f4a9) into master (918465d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2987   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files          90       90           
  Lines       12887    12887           
=======================================
  Hits         7054     7054           
  Misses       5833     5833           
Impacted Files Coverage Δ
shap/explainers/_tree.py 69.61% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@thatlittleboy thatlittleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trump-showing-lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xgboost ntree_limit deprecation warning
2 participants