Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: concatMap early first upstream issues #1499

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 26, 2024

This fixes the NPE #1498 and reveals a deadlock problem.

@jponge jponge added this to the 2.5.6 milestone Jan 26, 2024
@jponge jponge linked an issue Jan 26, 2024 that may be closed by this pull request
@jponge jponge requested a review from cescoffier January 26, 2024 18:02
@jponge jponge added the bug Something isn't working label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (32fdd3e) 89.33% compared to head (f18296b) 89.39%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1499      +/-   ##
============================================
+ Coverage     89.33%   89.39%   +0.06%     
+ Complexity     3368     3367       -1     
============================================
  Files           459      459              
  Lines         13435    13437       +2     
  Branches       1636     1637       +1     
============================================
+ Hits          12002    12012      +10     
- Misses          796      803       +7     
+ Partials        637      622      -15     
Files Coverage Δ
...llrye/mutiny/operators/multi/MultiConcatMapOp.java 88.88% <90.00%> (+1.47%) ⬆️

... and 12 files with indirect coverage changes

@jponge jponge merged commit 4ff850a into main Jan 26, 2024
7 checks passed
@jponge jponge deleted the fix/concatmap-early-null-innerUpstream branch January 26, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in MultiConcatMapOp
2 participants