-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions release workflow #2515
GitHub Actions release workflow #2515
Conversation
5d7dded
to
9518465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the first release is going to be fun :-D
<name>smallrye-reactive-messaging</name> | ||
<overwrite>true</overwrite> | ||
<changelog> | ||
<preset>conventional-commits</preset> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to check the changelog output jreleaser:changelog
). Another option is to adopt conventional commits going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even without adopting conventional commits it seemed ok. But yes that's an option.
Piece of cake :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on the changelog generation.
Other than that I recommend testing this on release candidates, because I also predict a few fun issues 🤣 (sadly, there's no proper way to test GH Actions, especially those who perform release tasks)
Famous last words |
Move build scripts to .build and call them only from the justfile
9518465
to
2b8d140
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but note we don't use jreleaser yet in health. But all release steps are there.
Inspired by the Mutiny release workflow using justfile