Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions release workflow #2515

Merged

Conversation

ozangunalp
Copy link
Collaborator

Inspired by the Mutiny release workflow using justfile

  • Adds maven wrapper
  • JReleaser for release notes
  • Changes the development version to 999-SNAPSHOT

@ozangunalp ozangunalp force-pushed the github_actions_release_workflow branch 2 times, most recently from 5d7dded to 9518465 Compare March 7, 2024 18:36
cescoffier
cescoffier previously approved these changes Mar 7, 2024
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the first release is going to be fun :-D

<name>smallrye-reactive-messaging</name>
<overwrite>true</overwrite>
<changelog>
<preset>conventional-commits</preset>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check the changelog output jreleaser:changelog). Another option is to adopt conventional commits going forward.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without adopting conventional commits it seemed ok. But yes that's an option.

@ozangunalp
Copy link
Collaborator Author

LGTM - the first release is going to be fun :-D

Piece of cake :)

jponge
jponge previously approved these changes Mar 7, 2024
Copy link
Member

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on the changelog generation.

Other than that I recommend testing this on release candidates, because I also predict a few fun issues 🤣 (sadly, there's no proper way to test GH Actions, especially those who perform release tasks)

@jponge
Copy link
Member

jponge commented Mar 7, 2024

LGTM - the first release is going to be fun :-D

Piece of cake :)

Famous last words

Move build scripts to .build and call them only from the justfile
@ozangunalp ozangunalp dismissed stale reviews from jponge and cescoffier via 2b8d140 March 7, 2024 21:10
@ozangunalp ozangunalp force-pushed the github_actions_release_workflow branch from 9518465 to 2b8d140 Compare March 7, 2024 21:10
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but note we don't use jreleaser yet in health. But all release steps are there.

@ozangunalp ozangunalp merged commit 282e776 into smallrye:main Mar 8, 2024
4 checks passed
@ozangunalp ozangunalp added this to the 4.19.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants