Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2519 Fix: PulsarOutgoingChannel tracing properties propagation #2520

Merged
merged 2 commits into from
Mar 13, 2024
Merged

#2519 Fix: PulsarOutgoingChannel tracing properties propagation #2520

merged 2 commits into from
Mar 13, 2024

Conversation

michalcukierman
Copy link
Contributor

No description provided.

@michalcukierman michalcukierman force-pushed the main branch 2 times, most recently from 974ed1b to 3f403b7 Compare March 9, 2024 14:04
@cescoffier cescoffier requested a review from ozangunalp March 11, 2024 06:51
@ozangunalp
Copy link
Collaborator

@michalcukierman Thank you for this! We better check this in io.smallrye.reactive.messaging.pulsar.tracing.TracingPropagationTest.
I suggest we add an assertion in testFromPulsarToAppToPulsar to check for "traceparent" property in the received message properties.

@ozangunalp
Copy link
Collaborator

@michalcukierman Here's my suggestion : fa5099b

@michalcukierman
Copy link
Contributor Author

Thanks @ozangunalp, thank you for the test I should have add it at first. It looks much better now.
And sorry for the late update, we are going to launch the product next week, so I have a lot on my plate.

@michalcukierman
Copy link
Contributor Author

I've added one more test for messages with PulsarOutgoingMessageMetadata, to cover this change:
https://github.com/smallrye/smallrye-reactive-messaging/pull/2520/files#diff-b9a66ad40b9d795a40fff17754b68b2bf3da86869a99eebc2581100198500a6aR128-R136

@ozangunalp ozangunalp merged commit 00ac1b3 into smallrye:main Mar 13, 2024
4 checks passed
@ozangunalp ozangunalp added this to the 4.19.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangunalp ozangunalp ozangunalp approved these changes

Assignees
No one assigned
Labels
pulsar
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michalcukierman @ozangunalp @cescoffier