From 6c4a257fbf723024d54c88cbdaa169c69911b954 Mon Sep 17 00:00:00 2001
From: Simeon Manolov <s.manolloff@gmail.com>
Date: Wed, 9 Oct 2024 18:07:47 +0300
Subject: [PATCH] disable Android (NDK25 is already removed from some GH
 runners)

https://github.com/actions/runner-images/issues/10614
---
 .github/workflows/github.yml | 80 +++++++++++++++++++-----------------
 1 file changed, 42 insertions(+), 38 deletions(-)

diff --git a/.github/workflows/github.yml b/.github/workflows/github.yml
index 1b00cca963..69c26084e3 100644
--- a/.github/workflows/github.yml
+++ b/.github/workflows/github.yml
@@ -87,20 +87,24 @@ jobs:
             cmake_args: -G Ninja
             preset: windows-mingw-conan-linux
             conan_profile: mingw32-linux.jinja
-          - platform: android-32
-            os: macos-14
-            extension: apk
-            preset: android-conan-ninja-release
-            conan_profile: android-32
-            conan_options: --conf tools.android:ndk_path=$ANDROID_NDK_ROOT
-            artifact_platform: armeabi-v7a
-          - platform: android-64
-            os: macos-14
-            extension: apk
-            preset: android-conan-ninja-release
-            conan_profile: android-64
-            conan_options: --conf tools.android:ndk_path=$ANDROID_NDK_ROOT
-            artifact_platform: arm64-v8a
+
+          # XXX: some runs already fail due to missing NDK 25
+          #      https://github.com/actions/runner-images/issues/10614
+
+          # - platform: android-32
+          #   os: macos-14
+          #   extension: apk
+          #   preset: android-conan-ninja-release
+          #   conan_profile: android-32
+          #   conan_options: --conf tools.android:ndk_path=$ANDROID_NDK_ROOT
+          #   artifact_platform: armeabi-v7a
+          # - platform: android-64
+          #   os: macos-14
+          #   extension: apk
+          #   preset: android-conan-ninja-release
+          #   conan_profile: android-64
+          #   conan_options: --conf tools.android:ndk_path=$ANDROID_NDK_ROOT
+          #   artifact_platform: arm64-v8a
           #
           # MMAI builds
           #
@@ -174,30 +178,30 @@ jobs:
         VCMI_BUILD_PLATFORM: x64
         MMAI: ${{matrix.mmai}}
 
-    # ensure the ccache for each PR is separate so they don't interfere with each other
-    # fall back to ccache of the vcmi/vcmi repo if no PR-specific ccache is found
-    - name: ccache for PRs
-      uses: hendrikmuhs/ccache-action@v1.2
-      if: ${{ github.event.number != '' }}
-      with:
-        key: ${{ matrix.preset }}-PR-${{ github.event.number }}
-        restore-keys: |
-          ${{ matrix.preset }}-PR-${{ github.event.number }}
-          ${{ matrix.preset }}-no-PR
-        # actual cache takes up less space, at most ~1 GB
-        max-size: "5G"
-        verbose: 2
-
-    - name: ccache for everything but PRs
-      uses: hendrikmuhs/ccache-action@v1.2
-      if: ${{ (github.repository == 'vcmi/vcmi' && github.event.number == '' && (github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/beta' || github.ref == 'refs/heads/master')) ||  github.repository != 'vcmi/vcmi' }}
-      with:
-        key: ${{ matrix.preset }}-no-PR
-        restore-keys: |
-          ${{ matrix.preset }}-no-PR
-        # actual cache takes up less space, at most ~1 GB
-        max-size: "5G"
-        verbose: 2
+    # # ensure the ccache for each PR is separate so they don't interfere with each other
+    # # fall back to ccache of the vcmi/vcmi repo if no PR-specific ccache is found
+    # - name: ccache for PRs
+    #   uses: hendrikmuhs/ccache-action@v1.2
+    #   if: ${{ github.event.number != '' }}
+    #   with:
+    #     key: ${{ matrix.preset }}-PR-${{ github.event.number }}
+    #     restore-keys: |
+    #       ${{ matrix.preset }}-PR-${{ github.event.number }}
+    #       ${{ matrix.preset }}-no-PR
+    #     # actual cache takes up less space, at most ~1 GB
+    #     max-size: "5G"
+    #     verbose: 2
+
+    # - name: ccache for everything but PRs
+    #   uses: hendrikmuhs/ccache-action@v1.2
+    #   if: ${{ (github.repository == 'vcmi/vcmi' && github.event.number == '' && (github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/beta' || github.ref == 'refs/heads/master')) ||  github.repository != 'vcmi/vcmi' }}
+    #   with:
+    #     key: ${{ matrix.preset }}-no-PR
+    #     restore-keys: |
+    #       ${{ matrix.preset }}-no-PR
+    #     # actual cache takes up less space, at most ~1 GB
+    #     max-size: "5G"
+    #     verbose: 2
 
     - name: Prepare Heroes 3 data
       env: